-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support tsconfig paths and package-relative imports [sc-22644] #1006
Merged
sorccu
merged 20 commits into
main
from
simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative
Jan 20, 2025
Merged
feat: support tsconfig paths and package-relative imports [sc-22644] #1006
sorccu
merged 20 commits into
main
from
simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorccu
force-pushed
the
simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative
branch
from
December 19, 2024 21:42
5ce630d
to
820dd82
Compare
This comment has been minimized.
This comment has been minimized.
sorccu
added
build
Issue regarding building and packaging
and removed
build
Issue regarding building and packaging
labels
Dec 23, 2024
🎉 Experimental release successfully published on npm
|
Closed
sorccu
force-pushed
the
simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative
branch
from
January 17, 2025 18:17
2fb1ffc
to
23f4942
Compare
This optionally allows the parser to massage the file structure into an alternate output format.
These files are currently not utilized by the backend but they might be in the near future.
Shares a common Parser (or Parsers, one per runtime) within a Session and avoids unnecessary AST walks for filePaths the parser has already seen when parsing other entrypoints. Share PackageFilesResolver so that its file caches can be shared within the same Parser (which is now also shared within the Session), and cache its result per filePath to avoid duplicate work. Helps use cases where there are multiple entrypoints that share common libraries.
Does not play well during a nested lookup when we're looking up a path that we've already resolved to a candidate with a .ts extension earlier in the process. Not a super useful feature anyway.
sorccu
force-pushed
the
simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative
branch
from
January 19, 2025 19:11
07cfcf4
to
b891d5e
Compare
sorccu
deleted the
simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative
branch
January 20, 2025 06:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
New Dependency Submission