Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tsconfig paths and package-relative imports [sc-22644] #1006

Merged

Conversation

sorccu
Copy link
Contributor

@sorccu sorccu commented Dec 18, 2024

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

@sorccu sorccu force-pushed the simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative branch from 5ce630d to 820dd82 Compare December 19, 2024 21:42
@sorccu sorccu marked this pull request as ready for review December 20, 2024 11:28
@sorccu sorccu added the build Issue regarding building and packaging label Dec 20, 2024

This comment has been minimized.

@sorccu sorccu added build Issue regarding building and packaging and removed build Issue regarding building and packaging labels Dec 23, 2024
Copy link

🎉 Experimental release successfully published on npm

npm install [email protected]

@sorccu sorccu mentioned this pull request Jan 2, 2025
@sorccu sorccu force-pushed the simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative branch from 2fb1ffc to 23f4942 Compare January 17, 2025 18:17
sorccu added 19 commits January 20, 2025 04:10
This optionally allows the parser to massage the file structure into an
alternate output format.
These files are currently not utilized by the backend but they might be
in the near future.
Shares a common Parser (or Parsers, one per runtime) within a Session and
avoids unnecessary AST walks for filePaths the parser has already seen when
parsing other entrypoints.

Share PackageFilesResolver so that its file caches can be shared within the
same Parser (which is now also shared within the Session), and cache
its result per filePath to avoid duplicate work.

Helps use cases where there are multiple entrypoints that share
common libraries.
Does not play well during a nested lookup when we're looking up a path that
we've already resolved to a candidate with a .ts extension earlier in the
process. Not a super useful feature anyway.
@sorccu sorccu force-pushed the simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative branch from 07cfcf4 to b891d5e Compare January 19, 2025 19:11
@sorccu sorccu merged commit 19656b8 into main Jan 20, 2025
3 checks passed
@sorccu sorccu deleted the simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative branch January 20, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue regarding building and packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant